refactor: commandline#46
Conversation
Greptile SummaryThis PR refactors the commandline feature by extracting a
Confidence Score: 2/5The commandline palette has multiple regressions — stale state on keyboard close, always-on key listeners with unintended effects, missing theme reset on backdrop close, and lost input styling — that together make the feature unreliable. The core close path via toggle() (Ctrl+K) leaves query and scope dirty, causing the palette to reopen in a wrong state. Combined with the always-active Escape listener and the theme-reset gap noted in earlier threads, the refactored controller introduces more breakage than the original on the main interaction paths. apps/frontend/src/features/commandline/components/commandline.tsx needs careful attention — both the toggle() close path and the global keydown handler logic.
|
| Filename | Overview |
|---|---|
| apps/frontend/src/features/commandline/components/commandline.tsx | Major refactor extracting a createCommandlineController hook; introduces several behavioural regressions including stale query/scope on Ctrl+K close, always-active key listener side effects, and missing input styling |
| apps/frontend/src/features/commandline/components/commandline-input.tsx | File deleted — its contents were inlined into commandline.tsx; no independent logic changes |
| apps/frontend/src/app/layout.tsx | Import updated from default to named export to match the refactored commandline component; straightforward change |
Reviews (3): Last reviewed commit: "revert keybind" | Re-trigger Greptile
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
No description provided.